[
https://issues.apache.org/jira/browse/MINIFI-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997272#comment-15997272
]
ASF GitHub Bot commented on MINIFI-258:
---------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114860818
--- Diff: libminifi/include/FlowController.h ---
@@ -64,8 +64,9 @@ class FlowController : public core::CoreComponent {
/**
* Flow controller constructor
*/
- FlowController(std::shared_ptr<core::Repository> provenance_repo,
- std::shared_ptr<core::Repository> flow_file_repo,
+ FlowController(const std::shared_ptr<core::Repository> &provenance_repo,
--- End diff --
The reason these were pass by value was that we wanted to ensure that we
increment the ref counter for flow controller. Thus we won't deallocate memory
during its scope. It's a safety mechanism and more importantly indicates that
these need to survive FlowController
> Avoid using singleton for Configure.
> -------------------------------------
>
> Key: MINIFI-258
> URL: https://issues.apache.org/jira/browse/MINIFI-258
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Reporter: marco polo
> Assignee: Bryan Rosander
>
> Avoiding a singleton for Configure will allow us to eventually support
> multiple, disparate flows. The object FlowConfiguration can be passed with
> the information in Configure. This has increased coupling dramatically while
> also limiting how configurations can be stored within minifi.
> It stands to reason that to eventually support C2 activities and to
> facilitate multiple configurations, we will need to remove state from the
> global level and make it something that is referenced from the objects which
> care ( proper encapsulation ).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
