[
https://issues.apache.org/jira/browse/MINIFI-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002908#comment-16002908
]
ASF GitHub Bot commented on MINIFI-304:
---------------------------------------
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/96
MINIFI-304: Update testing strategy
MINIFI-306: Move Docs and Docker cmake code into a separate module.
this will clean-up the end of the file. We will continue to do cleanup
but this has a great impact to improve the readability of the root
cmake
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-304
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/96.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #96
----
commit d4947cda45ee5eeb204148759121a3919224e017
Author: Marc Parisi <[email protected]>
Date: 2017-05-08T23:13:00Z
MINIFI-304: Update testing strategy
MINIFI-306: Move Docs and Docker cmake code into a separate module.
this will clean-up the end of the file. We will continue to do cleanup
but this has a great impact to improve the readability of the root
cmake
----
> Test Failures manifested by logger initialization failures.
> ------------------------------------------------------------
>
> Key: MINIFI-304
> URL: https://issues.apache.org/jira/browse/MINIFI-304
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Reporter: marco polo
> Assignee: marco polo
>
> statics within spdlog would not be initialized in time depending on the order
> of execution. As a result it is better to use no logging unless necessary.
> There are examples which use logging, but unless explicitly needed ( and
> captured into strings, for example ) we should instead turn logging off.
> Breaking this out into separate executables would be idea. This ticket will
> involve editing the cmake file to move tests into a separate file.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
