[
https://issues.apache.org/jira/browse/MINIFI-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013447#comment-16013447
]
ASF GitHub Bot commented on MINIFI-304:
---------------------------------------
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/96
@phrocker These changes look good and good to merge. Would it be easier if
we wait for #83 to finalize and merge first?
@kevdoran Definitely worth exploring. Want to create a JIRA and we can
evaluate at some point?
> Test Failures manifested by logger initialization failures.
> ------------------------------------------------------------
>
> Key: MINIFI-304
> URL: https://issues.apache.org/jira/browse/MINIFI-304
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Reporter: marco polo
> Assignee: marco polo
>
> statics within spdlog would not be initialized in time depending on the order
> of execution. As a result it is better to use no logging unless necessary.
> There are examples which use logging, but unless explicitly needed ( and
> captured into strings, for example ) we should instead turn logging off.
> Breaking this out into separate executables would be idea. This ticket will
> involve editing the cmake file to move tests into a separate file.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
