[
https://issues.apache.org/jira/browse/MINIFI-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010935#comment-16010935
]
ASF GitHub Bot commented on MINIFI-304:
---------------------------------------
Github user kevdoran commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/96
LGTM, but we may also want to take a look at the CMake integration approach
provided by Catch
([ParseAndAddCatchTests.cmake](https://github.com/philsquared/Catch/blob/master/contrib/ParseAndAddCatchTests.cmake)),
which will automatically scan from tests and add them:
https://github.com/philsquared/Catch/blob/master/docs/build-systems.md
> Test Failures manifested by logger initialization failures.
> ------------------------------------------------------------
>
> Key: MINIFI-304
> URL: https://issues.apache.org/jira/browse/MINIFI-304
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Reporter: marco polo
> Assignee: marco polo
>
> statics within spdlog would not be initialized in time depending on the order
> of execution. As a result it is better to use no logging unless necessary.
> There are examples which use logging, but unless explicitly needed ( and
> captured into strings, for example ) we should instead turn logging off.
> Breaking this out into separate executables would be idea. This ticket will
> involve editing the cmake file to move tests into a separate file.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
