[
https://issues.apache.org/jira/browse/MINIFI-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025021#comment-16025021
]
ASF GitHub Bot commented on MINIFI-296:
---------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118496711
--- Diff: libminifi/include/Site2SitePeer.h ---
@@ -72,8 +73,8 @@ class Site2SitePeer : public
org::apache::nifi::minifi::io::BaseStream {
explicit Site2SitePeer(Site2SitePeer &&ss)
: stream_(ss.stream_.release()),
host_(std::move(ss.host_)),
- port_(std::move(ss.port_)) {
- logger_ = logging::Logger::getLogger();
+ port_(std::move(ss.port_)),
+ logger_(ss.logger_) {
--- End diff --
since we are using move semantics here we should move the object and not
reference it. Since we were using a shared object before it didn't really make
any sense but since this is per class we should do std::move(ss.logger_)
> More configurable logging
> -------------------------
>
> Key: MINIFI-296
> URL: https://issues.apache.org/jira/browse/MINIFI-296
> Project: Apache NiFi MiNiFi
> Issue Type: Improvement
> Components: C++
> Reporter: marco polo
> Assignee: Bryan Rosander
> Priority: Minor
>
> The logging functionality would be more useful if it could be tuned on a
> per-class basis. This would allow us to set more detailed log levels for a
> place where trouble is suspected while reducing noise from other areas.
> Composable log appenders would allow us to have multiple sinks so that we
> would have a log appender that could "phone home" with information while
> concurrently logging to disk. Using a processor to do the same may be too
> onerous; however, it stands to reason that we may use the processor as the
> delivery mechanism, so we may eventually negate this issue entirely if it is
> decided that we should ship the log itself via a processor.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
