[
https://issues.apache.org/jira/browse/MINIFI-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025024#comment-16025024
]
ASF GitHub Bot commented on MINIFI-296:
---------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118500266
--- Diff: libminifi/include/core/logging/LoggerConfiguration.h ---
@@ -0,0 +1,147 @@
+/**
+ * @file LoggerConfiguration.h
+ * Logger class declaration
+ * This is a C++ wrapper for spdlog, a lightweight C++ logging library
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#ifndef __LOGGER_CONFIGURATION_H__
+#define __LOGGER_CONFIGURATION_H__
+
+#include <atomic>
+#include <map>
+#include <mutex>
+#include <string>
+#include "core/logging/Logger.h"
+#include "properties/Properties.h"
+
+#include "spdlog/spdlog.h"
+#include "spdlog/formatter.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace core {
+namespace logging {
+
+namespace internal {
+ /**
+ * This class should not be instantiated directly. Use LoggerFactory to
get an instance.
--- End diff --
^ Friend declarations can help enforce constraints stated in comments.
> More configurable logging
> -------------------------
>
> Key: MINIFI-296
> URL: https://issues.apache.org/jira/browse/MINIFI-296
> Project: Apache NiFi MiNiFi
> Issue Type: Improvement
> Components: C++
> Reporter: marco polo
> Assignee: Bryan Rosander
> Priority: Minor
>
> The logging functionality would be more useful if it could be tuned on a
> per-class basis. This would allow us to set more detailed log levels for a
> place where trouble is suspected while reducing noise from other areas.
> Composable log appenders would allow us to have multiple sinks so that we
> would have a log appender that could "phone home" with information while
> concurrently logging to disk. Using a processor to do the same may be too
> onerous; however, it stands to reason that we may use the processor as the
> delivery mechanism, so we may eventually negate this issue entirely if it is
> decided that we should ship the log itself via a processor.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
