[
https://issues.apache.org/jira/browse/MINIFI-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025018#comment-16025018
]
ASF GitHub Bot commented on MINIFI-296:
---------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118524108
--- Diff: libminifi/include/utils/StringUtils.h ---
@@ -89,6 +89,25 @@ class StringUtils {
s.end());
return s;
}
+
+ static std::vector<std::string> split(const std::string &str, const
std::string &delimiter) {
+ std::vector<std::string> result;
+ int last = 0;
+ int next = 0;
+ while ((next = str.find(delimiter, last)) != std::string::npos) {
+ result.push_back(str.substr(last, next - last));
+ last = next + delimiter.length();
+ }
+ result.push_back(str.substr(last, next - last));
+ return result;
+ }
+
+ static inline bool starts_with(const std::string &str, const std::string
&prefix) {
--- End diff --
rfind and find have a conditional to check the size of the argument, so
this is not necessary.
> More configurable logging
> -------------------------
>
> Key: MINIFI-296
> URL: https://issues.apache.org/jira/browse/MINIFI-296
> Project: Apache NiFi MiNiFi
> Issue Type: Improvement
> Components: C++
> Reporter: marco polo
> Assignee: Bryan Rosander
> Priority: Minor
>
> The logging functionality would be more useful if it could be tuned on a
> per-class basis. This would allow us to set more detailed log levels for a
> place where trouble is suspected while reducing noise from other areas.
> Composable log appenders would allow us to have multiple sinks so that we
> would have a log appender that could "phone home" with information while
> concurrently logging to disk. Using a processor to do the same may be too
> onerous; however, it stands to reason that we may use the processor as the
> delivery mechanism, so we may eventually negate this issue entirely if it is
> decided that we should ship the log itself via a processor.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
