xiaoxiang781216 commented on a change in pull request #179: macOS support for sim URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372533638
########## File path: arch/sim/src/Makefile ########## @@ -195,8 +195,15 @@ endif # Override in Make.defs if linker is not 'ld' -LDSTARTGROUP ?= --start-group -LDENDGROUP ?= --end-group +ifeq ($(HOSTOS),Darwin) + LDSTARTGROUP ?= + LDENDGROUP ?= + LDUNEXPORTSYMBOLS ?= -unexported_symbols_list $(HOSTOS)-names.dat Review comment: Emm, unexported_symbols_list doesn't support on Linux, but after searching we can install binutils and use gobjcopy? even for ld so we don't modify Makefile at all. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
