yamt commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372913101
##########
File path: arch/sim/src/sim/up_initialstate.c
##########
@@ -67,6 +67,6 @@
void up_initial_state(struct tcb_s *tcb)
{
memset(&tcb->xcp, 0, sizeof(struct xcptcontext));
Review comment:
the convention is, align _before_ a function call.
that is, from POV of the function being called, it will be aligned after
pushing RBP.
note that up_longjmp jumps into the function directly. (without pushing the
return address)
RSP at that point should not be aligned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
