xiaoxiang781216 commented on a change in pull request #179: macOS support for
sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372773380
##########
File path: arch/sim/src/sim/up_initialstate.c
##########
@@ -67,6 +67,6 @@
void up_initial_state(struct tcb_s *tcb)
{
memset(&tcb->xcp, 0, sizeof(struct xcptcontext));
Review comment:
My previous comment is wrong, but all places(up_use_stack/up_stack_frame)
which modify adj_stack_ptr already align this pointer to 16B boundary, the
extra subtraction just make the situation even worse, I can't understand why
this change fix your problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
