patacongo commented on a change in pull request #529: Stm32F7: add external ram config URL: https://github.com/apache/incubator-nuttx/pull/529#discussion_r390457260
########## File path: arch/arm/src/stm32f7/Kconfig ########## @@ -2136,6 +2136,14 @@ endchoice #"ULPI Selection" endmenu # OTG_HS Config +config STM32F7_EXTERNAL_RAM + bool "External RAM on FMC" + default n + depends on STM32F7_FMC + select ARCH_HAVE_HEAP2 + ---help--- + In addition to internal SDRAM, external RAM may be available through the FMC. + Review comment: Where is this new configuration option used? It is not used in arch/arm/src/stm32f7 so it does not belong there. Do you use it in your board? If so then it belongs in your boards/arm/stm32/your-board/Kconfig and it should be named CONFIG_YOURBOARD_EXTERNAL_RAM ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
