AlexanderVasiljev commented on issue #529: Stm32F7: add external ram config URL: https://github.com/apache/incubator-nuttx/pull/529#issuecomment-598069507 > Configuration is improperly scoped, improperly name, and in the wrong Kconfig file. > > Move unused configuration option to the /board/arm/stm32ft/your-board/Kconfig > > Rename the option to CONFIG_YOURBOARD_EXTERNAL_RAM I would like to insist to apply this patch as is. 1) STM32F7_EXTERNAL_RAM will select ARCH_HAVE_HEAP2, which is used in arch/arm/src/stm32f7/stm32_allocateheap.c. And there is no other way to select ARCH_HAVE_HEAP2. Now it is not obvious that stm32f7 has already support for second heap in arch/arm/src/stm32f7/stm32_allocateheap.c 2) Stm32 and stm32H7 aleady have the same options: STM32H7_EXTERNAL_RAM and STM32_EXTERNAL_RAM. For the sake of uniformity Stm32F7 should have the same option. Otherwise it is frustrating when migrating from stm32f4 to stm32f7 and not finding such a config.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
