AlexanderVasiljev commented on a change in pull request #529: Stm32F7: add external ram config URL: https://github.com/apache/incubator-nuttx/pull/529#discussion_r390770344
########## File path: arch/arm/src/stm32f7/Kconfig ########## @@ -2136,6 +2136,14 @@ endchoice #"ULPI Selection" endmenu # OTG_HS Config +config STM32F7_EXTERNAL_RAM + bool "External RAM on FMC" + default n + depends on STM32F7_FMC + select ARCH_HAVE_HEAP2 + ---help--- + In addition to internal SDRAM, external RAM may be available through the FMC. + Review comment: The sole purpose of STM32F7_EXTERNAL_RAM is to select ARCH_HAVE_HEAP2. ARCH_HAVE_HEAP2 is used in arch/arm/src/stm32f7/stm32_allocateheap.c There is no other way to select ARCH_HAVE_HEAP2. It is the same as in stm32h7. Stm32H7 has STM32H7_EXTERNAL_RAM, which just selects ARCH_HAVE_HEAP2. And Stm32 also has this option. STM32_EXTERNAL_RAM Only Stm32F7 is missing it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
