patacongo commented on issue #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/549#issuecomment-597975277 To me, I don't mind waiving some style warnings. The job is very big right now but will bet better in the future, I hope. I think we should think about community first and make sure that we are supportive of people who make a good effort. We will catch the error again another day. So, if you are satisified, I have no problem waiving the single remaining issue. I think you do not need my concurrence, I will always trust your judgement on things like this. This all only works because people have good intentions and we trust each other.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
