xiaoxiang781216 commented on issue #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/549#issuecomment-597989437 > > @yamt and @patacongo since the tool need time to improve what we face during the daliy development, how about we don't make the build test depends on style check? So we can ensure the change pass the build, but waive the style problem case by base. > > I think that is a great idea. I like giving the final decision to the committer. There are too many special cases like this where dividing a long line is worse the keeping the line too long. > > And we have to have some way to continue and make progress. It is important to fix style errors, but not as important as making progress and trying not to annoy our contributors too much. @liuguo09 please help change the workflow a litlte bit.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
