xiaoxiang781216 commented on issue #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/549#issuecomment-597981338 > my suggestion is to make nxstyle skip the check if the line includes a URL-like string. > because: > > * usually URLs are not under our control > * there's no good way to wrap URLs @yamt and @patacongo since the tool need time to improve what we face during the daliy development, how about we don't make the build test depends on style check? So we can ensure the change pass the build, but waive the style problem case by base.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
