hartmannathan commented on a change in pull request #1051:
URL: https://github.com/apache/incubator-nuttx/pull/1051#discussion_r427300138



##########
File path: arch/arm/src/stm32/hardware/stm32_dma_v1.h
##########
@@ -54,6 +54,10 @@
 #define DMA1                       (0)
 #define DMA2                       (1)
 
+#if defined(CONFIG_STM32_STM32G47XX)
+#  define HAVE_DMA_CHAN8
+#endif

Review comment:
       > This should come in from chip.h or Kconfig.
   
   I think there should there be **two** defines from Kconfig: HAVE_DMA1_CHAN8 
and HAVE_DMA2_CHAN678.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to