hartmannathan commented on a change in pull request #1051:
URL: https://github.com/apache/incubator-nuttx/pull/1051#discussion_r427303457
##########
File path: arch/arm/src/stm32/Kconfig
##########
@@ -1129,15 +1129,80 @@ config ARCH_CHIP_STM32F469N
select STM32_STM32F469
select STM32_HAVE_ETHMAC
+config ARCH_CHIP_STM32G474C
Review comment:
> Looks good.
> But I'm not sure if we need additional options for STM32_STM32G474M,
STM32_STM32G474R, etc.
> Shouldn't we keep chip-specific options just under ARCH_CHIP_STM32G474M,
ARCH_CHIP_STM32G474R, etc ?
> Then leave only STM32_STM32G47XX as the common configuration for the G47XX
familly.
> There is currently no consistency regarding this in Kconfig
Yes, Kconfig is inconsistent. I tried to follow what most other chips were
doing.
What would your preference be?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
