hartmannathan commented on a change in pull request #1051:
URL: https://github.com/apache/incubator-nuttx/pull/1051#discussion_r426298204



##########
File path: arch/arm/src/stm32/Kconfig
##########
@@ -1129,15 +1129,80 @@ config ARCH_CHIP_STM32F469N
        select STM32_STM32F469
        select STM32_HAVE_ETHMAC
 
+config ARCH_CHIP_STM32G474C

Review comment:
       If I do what you suggest, the second letter determines the flash size:
   
   STM32G474x**E** = 512Kbyte
   STM32G474x**C** = 256Kbyte
   STM32G474x**B** = 128Kbyte
   
   How do I handle that? Like this:
   
   ```suggestion
   config ARCH_CHIP_STM32G474CB
        bool "STM32G474CB"
        select STM32_STM32G47XX
        select STM32_STM32G474C
        select STM32_FLASH_CONFIG_B
   ```
   
   Note that STM32_FLASH_CONFIG_B is part of a 'choice' and I don't see any 
other chip doing it that way.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to