acassis commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1435077054
##########
drivers/mtd/Kconfig:
##########
@@ -382,10 +384,10 @@ config AT24XX_SIZE
int "AT24xx size (Kbit)"
default 64
---help---
- This is the XX in the AT24Cxx part number. For example, if you
have a
- AT 24C512, then the correct value is 512. This value is also
the capacity
- of the part in kilobits. For example, the 24C512 supports 512
Kbits or
- 512 /8 = 64 KiB.
+ This is the XX in the AT24Cxx part number. For example, if you
have
+ an AT24C512, then the correct value is 512.
+ This value is also the capacity of the part in kilobits.
+ For example, the 24C512 supports 512 Kbits or 512 /8 = 64 KiB.
Review Comment:
@TimJTi This is the point: AT24C512 is 512Kbit but the default value is set
to 64Kbit according with the prompt message: "AT24xx size (Kbit)", understood
now?
The prompt should be: "AT24xx size (in KiB)" and the Help message also need
to be updated, it says that the entered value is in Kilo Bit, but actually it
is in KiB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
