TimJTi commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1435124953
##########
drivers/mtd/Kconfig:
##########
@@ -382,10 +384,10 @@ config AT24XX_SIZE
int "AT24xx size (Kbit)"
default 64
---help---
- This is the XX in the AT24Cxx part number. For example, if you
have a
- AT 24C512, then the correct value is 512. This value is also
the capacity
- of the part in kilobits. For example, the 24C512 supports 512
Kbits or
- 512 /8 = 64 KiB.
+ This is the XX in the AT24Cxx part number. For example, if you
have
+ an AT24C512, then the correct value is 512.
+ This value is also the capacity of the part in kilobits.
+ For example, the 24C512 supports 512 Kbits or 512 /8 = 64 KiB.
Review Comment:
I disagree; or I am being very stupid!
The value you enter in Kconfig is in kbits as it says. The default is 64
kbits.
The example in the help is for an AT24C512, 512bits, which is 64KiB.
It might be inconsistent that the help example doesn't match the default,
but it is not wrong as such.
Would you like me to change the example - in part of the Kconfig that is
unrelated to this PR - to be for an AT24C64, 64kbit and therefore 8KiB?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
