acassis commented on code in PR #11423:
URL: https://github.com/apache/nuttx/pull/11423#discussion_r1435880084
##########
drivers/mtd/Kconfig:
##########
@@ -382,10 +384,10 @@ config AT24XX_SIZE
int "AT24xx size (Kbit)"
default 64
---help---
- This is the XX in the AT24Cxx part number. For example, if you
have a
- AT 24C512, then the correct value is 512. This value is also
the capacity
- of the part in kilobits. For example, the 24C512 supports 512
Kbits or
- 512 /8 = 64 KiB.
+ This is the XX in the AT24Cxx part number. For example, if you
have
+ an AT24C512, then the correct value is 512.
+ This value is also the capacity of the part in kilobits.
+ For example, the 24C512 supports 512 Kbits or 512 /8 = 64 KiB.
Review Comment:
Ok, I think I was fooled by the comment "This value is also the capacity..."
and "For example 512Kbits... = 64 KiB"
I was assuming the the XX = 64 was the 64 KiB, because it is mixing two
information with same value:
```
This is the XX in the AT24Cxx part number. For example, if you
have
an AT24C512, then the correct value is 512.
This value is also the capacity of the part in kilobits.
For example, the 24C512 supports 512 Kbits or 512 /8 = 64 KiB.
```
If it was the default value of 64 (AT24C64), the example could be clear:
```
For example, the 24C64 supports 64 Kbits or 64 /8 = 8 KiB.
```
I think this Help is clear, but of course, the example with same 64 value
could fool other people :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
