anchao commented on code in PR #11542:
URL: https://github.com/apache/nuttx/pull/11542#discussion_r1451831802


##########
sched/task/task_activate.c:
##########
@@ -94,4 +94,11 @@ void nxtask_activate(FAR struct tcb_s *tcb)
     }
 
   leave_critical_section(flags);
+
+#if CONFIG_TASK_NAME_SIZE>0

Review Comment:
   ```suggestion
   #if CONFIG_TASK_NAME_SIZE > 0
   ```



##########
sched/task/task_activate.c:
##########
@@ -94,4 +94,11 @@ void nxtask_activate(FAR struct tcb_s *tcb)
     }
 
   leave_critical_section(flags);
+
+#if CONFIG_TASK_NAME_SIZE>0
+  sinfo("%s pid=%d,TCB=%p\n", tcb->name,

Review Comment:
   Is the printed log information enough to know whether it is active or exit?



##########
sched/task/task_activate.c:
##########
@@ -94,4 +94,11 @@ void nxtask_activate(FAR struct tcb_s *tcb)
     }
 
   leave_critical_section(flags);
+

Review Comment:
   The task may switched at line 93



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to