anchao commented on code in PR #11542:
URL: https://github.com/apache/nuttx/pull/11542#discussion_r1451887328


##########
sched/task/task_exit.c:
##########
@@ -88,6 +89,13 @@ int nxtask_exit(void)
   dtcb = this_task();
 #endif
 
+#if CONFIG_TASK_NAME_SIZE > 0

Review Comment:
   It seems there are some redundant logs in up_exit(), maybe these can be 
removed:
   
   ```
   arch/misoc/src/minerva/minerva_exit.c:65:  sinfo("TCB=%p exiting\n", tcb);
   arch/misoc/src/lm32/lm32_exit.c:65:  sinfo("TCB=%p exiting\n", tcb);
   arch/avr/src/common/avr_exit.c:64:  sinfo("TCB=%p exiting\n", tcb);
   arch/ceva/src/common/ceva_exit.c:61:  sinfo("TCB=%p exiting\n", tcb);
   arch/xtensa/src/common/xtensa_exit.c:65:  sinfo("TCB=%p exiting\n", tcb);
   arch/sparc/src/common/sparc_exit.c:65:  sinfo("TCB=%p exiting\n", tcb);
   arch/z16/src/common/z16_exit.c:63:  sinfo("TCB=%p exiting\n", tcb);
   arch/z16/src/common/z16_exit.c:76:  sinfo("New Active Task TCB=%p\n", tcb);
   arch/x86/src/common/x86_exit.c:64:  sinfo("TCB=%p exiting\n", tcb);
   arch/hc/src/common/hc_exit.c:63:  sinfo("TCB=%p exiting\n", tcb);
   arch/z80/src/common/z80_exit.c:65:  sinfo("TCB=%p exiting\n", tcb);
   arch/z80/src/common/z80_exit.c:78:  sinfo("New Active Task TCB=%p\n", tcb);
   arch/sim/src/sim/sim_exit.c:61:  sinfo("TCB=%p exiting\n", this_task());
   arch/sim/src/sim/sim_exit.c:72:  sinfo("New Active Task TCB=%p\n", tcb);
   arch/x86_64/src/common/x86_64_exit.c:63:  sinfo("TCB=%p exiting\n", 
this_task());
   arch/or1k/src/common/or1k_exit.c:65:  sinfo("TCB=%p exiting\n", tcb);
   arch/risc-v/src/common/riscv_exit.c:65:  sinfo("TCB=%p exiting\n", tcb);
   arch/renesas/src/common/renesas_exit.c:63:  sinfo("TCB=%p exiting\n", tcb);
   arch/arm/src/common/arm_exit.c:65:  sinfo("TCB=%p exiting\n", tcb);
   arch/mips/src/common/mips_exit.c:65:  sinfo("TCB=%p exiting\n", tcb);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to