yf13 commented on code in PR #11542:
URL: https://github.com/apache/nuttx/pull/11542#discussion_r1451846126


##########
sched/task/task_activate.c:
##########
@@ -94,4 +94,11 @@ void nxtask_activate(FAR struct tcb_s *tcb)
     }
 
   leave_critical_section(flags);
+

Review Comment:
   Yes it maybe switched out thus the log comes late. it is fine if meaning of 
this log is "task is already activated". It is at current location because logs 
are telling facts, not possiblities. Normally the task in question doesn't show 
up thus we rely on these facts to judge the system behavior.
   
   doing it at line 86 may be fine but upon log time the task hasn't get chance 
to run yet.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to