xiaoxiang781216 edited a comment on pull request #1187: URL: https://github.com/apache/incubator-nuttx/pull/1187#issuecomment-642031583
> @xiaoxiang781216 why is this needed? Why did you take the approach of removing the union? You mean the union inside exitinfo_s, this struct is added by me in commit: https://github.com/apache/incubator-nuttx/pull/1189/commits/843ad796f511043d5b28ce8100b65ba078955b7e And find that the logic can be simplified more by removing the union. > Where are the test cases with all the permutations of the CONFIG_* that control the changes? Now we just have ostest. I run the change with ostest, no problem found so far. Yes, the test case is very little. Can you improve in this area? If your concern is whether the change can build successfully with all possible CONFIG_* combination, I think the github action and apache jenkin already build all most board config. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
