xiaoxiang781216 commented on a change in pull request #1187:
URL: https://github.com/apache/incubator-nuttx/pull/1187#discussion_r438252132
##########
File path: sched/task/task_delete.c
##########
@@ -143,6 +144,15 @@ int task_delete(pid_t pid)
goto errout;
}
+#ifdef HAVE_GROUP_MEMBERS
+ /* Kill all of the children of the task. This will not kill the currently
+ * running task/pthread (this_task). It will kill the main thread of the
+ * task group if this_task is a pthread.
+ */
+
+ group_kill_children(rtcb);
Review comment:
> The PR summary does not does not describe the changes of all of the 11
commits. This must be broken into separately traceable PRs.
Because nobody review my PR more than 7 days and some late patch depend on
the previous one, I have to accumulate the patch in this PR. Anyway, I will
remove the new patch from the list and send new PR when this PR get merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
