pussuw commented on code in PR #13978: URL: https://github.com/apache/nuttx/pull/13978#discussion_r1793373957
########## arch/arm64/src/common/Make.defs: ########## @@ -119,3 +119,7 @@ endif ifeq ($(CONFIG_ARM64_SEMIHOSTING_HOSTFS),y) CMN_CSRCS += arm64_hostfs.c endif + +ifeq ($(CONFIG_ARCH_HAVE_DEBUG),y) Review Comment: You should make a config flag something like CONFIG_ARCH_USE_DEBUG (or similar) to give the user an option to leave the big module arm64_hwdebug.c out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
