pussuw commented on code in PR #13978:
URL: https://github.com/apache/nuttx/pull/13978#discussion_r1793407889
##########
arch/arm64/src/common/arm64_fatal.c:
##########
@@ -527,10 +527,10 @@ static int arm64_exception_handler(struct regs_context
*regs)
if (ret != 0)
{
- sinfo("CurrentEL: %s\n", el_str);
- sinfo("ESR_ELn: 0x%" PRIx64 "\n", esr);
- sinfo("FAR_ELn: 0x%" PRIx64 "\n", far);
- sinfo("ELR_ELn: 0x%" PRIx64 "\n", elr);
+ serr("CurrentEL: %s\n", el_str);
Review Comment:
You could even change the most critical messages to _alert(), like which
exception occurred.
Also, ESR, FAR and ELR are absolutely vital information when taking a fatal
exception where you absolutely CANNOT trust the stack contents (integer
context).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
