yamt opened a new pull request, #14695:
URL: https://github.com/apache/nuttx/pull/14695

   ## Summary
   
   Disable SYSLOG_DEFAULT by default because the implementation is problematic.
   See https://github.com/apache/nuttx/issues/14662 for the discussion. Also, 
make it depend on EXPERIMENTAL to discourage it.
   
   Instead, enable SYSLOG_CONSOLE for a bit more cases.
   
   An alternative would be to introduce/extend some serialization mechanism 
(eg. enter_critical_section, which is currently used by the serial driver to 
interact with interrupts) to cover up_putc users including SYSLOG_DEFAULT. 
While it works, it doesn't sound attractive to me to introduce this kind of 
complexity to up_putc, which is supposed to be a very low-level machinary used 
early in the boot. Also, the implementation of such serialization can be 
complex because how up_putc works is basically device-specific and how it 
corresponds to other devices on the system (eg. uarts) isn't obvious to the 
upper layers.
   
   ## Impact
   
   this would affect many board configurations.
   
   ## Testing
   
   tested for esp32s3-devkitc, with a few unrelated patches.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to