yamt commented on code in PR #14695:
URL: https://github.com/apache/nuttx/pull/14695#discussion_r1833814177
##########
drivers/syslog/Kconfig:
##########
@@ -267,19 +267,25 @@ config SYSLOG_STREAM
config SYSLOG_CONSOLE
bool "Log to /dev/console"
- default !ARCH_LOWPUTC && !SYSLOG_CHAR && !RAMLOG_SYSLOG &&
!SYSLOG_RPMSG && !SYSLOG_RTT
+ default !SYSLOG_CHAR && !RAMLOG_SYSLOG && !SYSLOG_RPMSG && !SYSLOG_RTT
Review Comment:
it's a valid concern.
IMO, using syslog from interrupt is a design mistake.
anyway, it won't be a disaster as syslog_device.c already has a check for
that case. (syslog_dev_outputready)
for panic, maybe it's enough to make it fall back to up_putc if
g_nx_initstate == OSINIT_PANIC.
as the panic logic should have already stopped moving parts (eg.
pause_all_cpu) at that point, it should be ok to use up_putc in that case.
how do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
