nuttxpr commented on PR #14695: URL: https://github.com/apache/nuttx/pull/14695#issuecomment-2463771039
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. Here's why: * **Insufficient Detail in Summary:** While the summary explains *why* the change is needed, it lacks detail on *how* `SYSLOG_CONSOLE` is enabled for more cases. Specifics are crucial. * **Impact Understated:** "This would affect many board configurations" is vague. The impact section needs to be filled out completely with YES/NO answers and descriptions for *each* category. Consider: * **User Impact:** Will users notice a change in logging behavior? Will configuration files need updating? * **Build Impact:** Are there new Kconfig options? * **Hardware Impact:** Does this affect any specific architectures or boards disproportionately? * **Documentation Impact:** Does documentation need updating to reflect the new default and the EXPERIMENTAL dependency? * **Security Impact:** Are there any potential security implications of disabling the default syslog and relying more on the console? * **Compatibility Impact:** Does this break any existing configurations? * **Missing Test Details:** The testing section is insufficient. * **Build Hosts:** Provide details about the build host OS, CPU architecture, and compiler version. * **Targets:** Be specific about the ESP32S3 configuration used. * **Logs:** "Tested with a few unrelated patches" is unacceptable. Provide *actual* before-and-after logs demonstrating the change in syslog behavior. Show how the change fixes the issue described in the linked GitHub issue. In short, the PR needs significantly more detail in the Impact and Testing sections to meet the requirements. The Summary could also benefit from more specifics about the implementation of the `SYSLOG_CONSOLE` changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
