tmedicci commented on PR #14701: URL: https://github.com/apache/nuttx/pull/14701#issuecomment-2464922749
> I would like feedback on how this change should be managed. I made it so that the feature will be active if there is 1 LCD layer. The impact is that double the memory will be allocated compared to before this change, which could cause users to have insufficient memory after upgrading. Should it be a Kconfig option? Yes, I think so. You can turn `ESP32S3_LCD_DBLBUFFERED` a Kconfig option that depends on CONFIG_ESP32S3_LCD_BUFFER_LAYERS being `= 1` (just like [here](https://github.com/apache/incubator-nuttx/blob/b6d2dc6c5487ffa957eaa524e02e9699b1f6dacc/drivers/lcd/Kconfig#L1279)) and can be enabled/disabled by the user (default to `y`, I think). You can insert in `help` the warning about the memory usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
