liamHowatt commented on code in PR #14701: URL: https://github.com/apache/nuttx/pull/14701#discussion_r1836548619
########## arch/xtensa/src/esp32s3/esp32s3_lcd.c: ########## @@ -300,13 +310,16 @@ static const struct fb_videoinfo_s g_base_videoinfo = /* This structure provides the base layer interface */ -static const struct fb_vtable_s g_base_vtable = +static struct fb_vtable_s g_base_vtable = Review Comment: The `fb_remove_paninfo(&g_base_vtable, FB_NO_OVERLAY);` I added takes a `FAR struct fb_vtable_s *vtable`. Looks like `fb_remove_paninfo` does not modify it, though. Maybe the parameter could be made const? See https://github.com/apache/nuttx/blob/52b0df1ce6cdcc99b44700b20a2bc3351285eee0/drivers/video/fb.c#L1607 Otherwise, should I keep the vtable const in esp32s3_lcd.c and cast to non-`const`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
