liamHowatt commented on PR #14701: URL: https://github.com/apache/nuttx/pull/14701#issuecomment-2471009537
I'm going to make some changes I think. I did this some time ago and wanted to remember why I made it work for 1 layer only. I don't think there was a reason, after analyzing. However, I think the >1 layer support is incomplete. If there are two layers, `lcd_interrupt` alternates between layers, DMAing their framebuffers out. When the `getvideoinfo` or `getplaneinfo` ioctl is called, a random layer's info is returned. The layer which was last alternated to is the current layer and its info is returned. I'm going to update this PR to continue using the random `CURRENT_LAYER` getter pattern until it's properly addressed in another PR or even this PR if you wish. The new `esp32s3_lcd_base_pandisplay` is blocking due to `esp32s3_dma_wait_idle`. I think I could/should use a critical section to set a flag which `lcd_interrupt` checks to know if the buffer should be panned and that's where `esp32s3_dma_setup` would be called. Are force-pushes preferred? Squash merging isn't normally done? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
