raiden00pl commented on code in PR #14695:
URL: https://github.com/apache/nuttx/pull/14695#discussion_r1835636744
##########
drivers/syslog/Kconfig:
##########
@@ -267,19 +267,25 @@ config SYSLOG_STREAM
config SYSLOG_CONSOLE
bool "Log to /dev/console"
- default !ARCH_LOWPUTC && !SYSLOG_CHAR && !RAMLOG_SYSLOG &&
!SYSLOG_RPMSG && !SYSLOG_RTT
+ default !SYSLOG_CHAR && !RAMLOG_SYSLOG && !SYSLOG_RPMSG && !SYSLOG_RTT
Review Comment:
Printing from interrupts only makes sense when we are debugging and
CONFIG_DEBUG_FEATURES=y (otherwise info/warn/err macros do nothing). Maybe for
now we can just add a condition that SYSLOG_DEFAULT=y depends also on
DEBUG_FEATURES
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
