nuttxpr commented on PR #15267: URL: https://github.com/apache/nuttx/pull/15267#issuecomment-2551128248
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. This PR description lacks crucial information required by the NuttX guidelines. Here's why and what's missing: * **Summary is insufficient:** It mentions *what* file changed but not *why* the change is necessary. What problem did the big lock cause? What are the benefits of the small lock? How does the locking mechanism work now? * **Impact is incomplete:** The impact section barely touches on the required details. Consider all the points and explicitly answer NO or YES with explanations where needed. For example: * **Is new feature added? Is existing feature changed?** (YES - locking mechanism changed) * **Impact on user?** (Potentially YES - if timing sensitive code relies on RTC) * **Impact on build?** (Likely NO, but state it explicitly) * **Impact on hardware?** (Likely YES - specific to ESP32/ESP8266, explain) * **Impact on documentation?** (Maybe YES if the locking behavior has changed and needs to be documented.) * **Impact on security?** (Consider race conditions etc.) * **Impact on compatibility?** (Crucial - does this break existing code?) * **Testing is inadequate:** "ci" is not acceptable. Provide actual log output *before* and *after* the change demonstrating the problem being solved and the correct behavior after the fix. Be specific about the host and target environments used for testing. Examples: * Build Host(s): Linux (Ubuntu 20.04), x86_64, GCC 10.3.0 * Target(s): sim:qemu-esp32 In short, the PR needs significantly more detail to be considered acceptable. Provide the missing context and demonstrate the change works as intended with clear testing logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
