xiaoxiang781216 commented on code in PR #15267:
URL: https://github.com/apache/nuttx/pull/15267#discussion_r1890432915
##########
arch/risc-v/src/common/espressif/esp_rtc.c:
##########
@@ -566,7 +575,7 @@ static int esp_rtc_cancelalarm(struct rtc_lowerhalf_s
*lower, int alarmid)
return -ENODATA;
}
- flags = spin_lock_irqsave(NULL);
+ flags = spin_lock_irqsave(&g_rtc_lowerhalf.lock);
Review Comment:
ditto
##########
arch/risc-v/src/common/espressif/esp_rtc.c:
##########
@@ -510,7 +519,7 @@ static int esp_rtc_setrelative(struct rtc_lowerhalf_s
*lower,
if (alarminfo->reltime > 0)
{
- flags = spin_lock_irqsave(NULL);
+ flags = spin_lock_irqsave(&g_rtc_lowerhalf.lock);
Review Comment:
should cast from low
##########
arch/risc-v/src/common/espressif/esp_rtc.c:
##########
@@ -420,13 +422,12 @@ static bool esp_rtc_havesettime(struct rtc_lowerhalf_s
*lower)
****************************************************************************/
#if defined(CONFIG_RTC_DRIVER) && defined(CONFIG_RTC_ALARM)
-static int esp_rtc_setalarm(struct rtc_lowerhalf_s *lower,
+static int esp_rtc_setalarm_nolock(struct rtc_lowerhalf_s *lower,
const struct lower_setalarm_s *alarminfo)
Review Comment:
@hujun260 not change here
##########
arch/risc-v/src/common/espressif/esp_rtc.c:
##########
@@ -616,7 +625,7 @@ static int esp_rtc_rdalarm(struct rtc_lowerhalf_s *lower,
priv = (struct esp_rtc_lowerhalf_s *)lower;
- flags = spin_lock_irqsave(NULL);
+ flags = spin_lock_irqsave(&g_rtc_lowerhalf.lock);
Review Comment:
cast from lower
##########
arch/risc-v/src/common/espressif/esp_rtc.c:
##########
@@ -474,10 +472,21 @@ static int esp_rtc_setalarm(struct rtc_lowerhalf_s *lower,
esp_hr_timer_start(cbinfo->alarm_hdl, cbinfo->deadline_us, false);
- spin_unlock_irqrestore(NULL, flags);
-
return OK;
}
+
+static int esp_rtc_setalarm(struct rtc_lowerhalf_s *lower,
+ const struct lower_setalarm_s *alarminfo)
+{
+ irqstate_t flags;
+ int ret;
+
+ flags = spin_lock_irqsave(&g_rtc_lowerhalf.lock);
Review Comment:
cast from lower
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
