xiaoxiang781216 commented on code in PR #15267:
URL: https://github.com/apache/nuttx/pull/15267#discussion_r1890137392
##########
arch/risc-v/src/common/espressif/esp_rtc.c:
##########
@@ -420,13 +422,12 @@ static bool esp_rtc_havesettime(struct rtc_lowerhalf_s
*lower)
****************************************************************************/
#if defined(CONFIG_RTC_DRIVER) && defined(CONFIG_RTC_ALARM)
-static int esp_rtc_setalarm(struct rtc_lowerhalf_s *lower,
+static int esp_rtc_setalarm_nolock(struct rtc_lowerhalf_s *lower,
const struct lower_setalarm_s *alarminfo)
Review Comment:
```suggestion
const struct lower_setalarm_s *alarminfo)
```
##########
arch/risc-v/src/common/espressif/esp_rtc.c:
##########
@@ -143,6 +143,8 @@ static int esp_rtc_rdalarm(struct rtc_lowerhalf_s *lower,
* Private Data
****************************************************************************/
+static spinlock_t g_rtc_lock = SP_UNLOCKED;
Review Comment:
should we move to esp_rtc_lowerhalf_s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
