no1wudi commented on PR #15396: URL: https://github.com/apache/nuttx/pull/15396#issuecomment-2566983666
> Why make things dependent on CONFIG_ARCH_RV_HARTID_BASE? Without this patch you can overload riscv_hartid_to_cpuid / riscv_cpuid_to_hartid? I'd prefer this breaking change was not merged at all... @pussuw I am attempting to decouple the implementation of CONFIG_RISCV_PERCPU_SCRATCH and riscv_mhartid, as the SCRATCH register is generally always available. In the current implementation, it seems that only the CONFIG_ARCH_RV_HARTID_BASE configuration affects the behavior of riscv_mhartid (when it is set to 0, the CPU ID and HART ID have a 1:1 mapping). Do you have any other suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
