pussuw commented on code in PR #15396:
URL: https://github.com/apache/nuttx/pull/15396#discussion_r1906698598


##########
arch/risc-v/src/common/riscv_macros.S:
##########
@@ -359,7 +359,7 @@
  ****************************************************************************/
 
 .macro  riscv_mhartid out
-#ifdef CONFIG_RISCV_PERCPU_SCRATCH

Review Comment:
   This dependency is exactly to the PERCPU_SCRATCH register? If it is not 
initialized you will return garbage by reading it (you will dereference NULL in 
fact)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to