no1wudi commented on PR #15396:
URL: https://github.com/apache/nuttx/pull/15396#issuecomment-2567465976
> I use an overloaded version (defined by board logic) of hartid<->cpuid
mapping in my downstream project. This was the whole point to define those as
weak symbols. Please do not break this functionality.
Another point to note is that in this PR, CONFIG_ARCH_RV_HARTID_BASE is used
to select the implementation of up_cpu_index. Please confirm if this aligns
with your requirements.
```c
#ifdef CONFIG_ARCH_HAVE_MULTICPU
#if CONFIG_ARCH_RV_HARTID_BASE != 0
int up_cpu_index(void) noinstrument_function;
#else
noinstrument_function static inline int up_cpu_index(void)
{
return READ_CSR(CSR_MHARTID);
}
#endif /* CONFIG_ARCH_RV_HARTID_BASE */
#endif /* CONFIG_ARCH_HAVE_MULTICPU */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
