keever50 commented on PR #15828: URL: https://github.com/apache/nuttx/pull/15828#issuecomment-2695199224
@linguini1 I see that you added the IOCTL commands, however i would suggest looking at https://github.com/apache/nuttx/issues/15856 maybe. The common API is still being worked on. I just started implementing the features into ioctl.h Maybe you can look at that? It is fine if you want to do it yourself too. The main difference between my common IOCTL and yours is i tagged LoRa related commands with WLIOC_LORA_x. This is done to keep some seperation between two obviously different command groups. Personally it feels "messy" when all modulation types are considered common. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
