linguini1 commented on PR #15828: URL: https://github.com/apache/nuttx/pull/15828#issuecomment-2696059847
> But i think as long the already established common ones stay completely untouched and your solution doesn't get away in this process, its fine. The only one I will be touching is the TXPWR commands, to change from int32_t dBm to int32_t 0.01 dBm, as per the earlier discussion on this PR. > I think just moving them a bit down under a comment also is completely OK. Okay, I can definitely make that change easily! > I'm really happy that people start to add LoRa to NuttX though! I can really really use these features. Thank you for doing this Me as well, I'm very excited about your work, too. My rocketry team wants to move away from the integrated RN2483 and towards the SX series LoRa chips, so your work is a huge help in that direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
