linguini1 commented on PR #15828: URL: https://github.com/apache/nuttx/pull/15828#issuecomment-2695612211
> @linguini1 Ah okay i understand! I do feel a bit uncomfortable knowing that the experimental changes will touch the already established common IOCTL. Which is the part that is kinda not experimental. What i did for the SX126x, I made seperate commands specifically for the SX126x and left the already common ones untouched for the time being. Ill remove or change these sx126x's later when merging with the future API. > > So i suggest maybe only adding the name of your driver infront of the commands for this temporary experimental phase? Leaving the already established common commands(section) untouched. Might provide a smoother porting experience. > > Lets see what the others think. I see, I assumed we would just rework those common commands entirely. I think @raiden00pl mentioned that he was (afaik) the only user of the SX127X driver and was fine with having those commands be completely changed. As far as I'm aware, the only drivers using WIOCTL commands right now are the SX127X, your SX126X and my RN2XX3 drivers. I wouldn't mind changing the WIOCTL commands I added to be specific to the RN2XX3 in the interim though, I just assumed they'd be overhauled shortly anyways. I can make that change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
