jlaitine commented on code in PR #16194:
URL: https://github.com/apache/nuttx/pull/16194#discussion_r2074810210


##########
sched/semaphore/sem_destroy.c:
##########
@@ -61,6 +61,9 @@
 int nxsem_destroy(FAR sem_t *sem)
 {
   int32_t old;
+  bool mutex = NXSEM_IS_MUTEX(sem);
+  FAR atomic_t *const val = mutex ? NXSEM_MHOLDER(sem) : NXSEM_COUNT(sem);

Review Comment:
   not right, this reads "val is a constant pointer to FAR atomic_t". It is not 
"FAR pointer to constant val". Const is there just to note that the pointer is 
not changing in this scope. If you dislike "const" as a word, I can surely 
remove it.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to