ppisa commented on issue #15319: URL: https://github.com/apache/nuttx/issues/15319#issuecomment-2867098038
There has been contributed reviewed support which worked on all three PCNT channels. Initially without complexity of the HAL and it has been straightforward. Then Martin @Vajnar switched code to be based on HAL after raised demand by Espressif. Code worked, provided 16-modulo value which could be easily extended to 32-bits by the driver use. The test code to control motor over WiFi has been implemented by him as well, etc. Then his code has been partially reused, but mostly replaced by Espressif pull request https://github.com/apache/nuttx/pull/15079. I understand that you want to extended support to more chip variants etc. But it broke already working functionality and makes code much more complex with much higher and necessary overhead. As Martin reports, range is hard limited to -1000 to +1000 etc. I have fear that tehre can be lose of the counts because counter seems to be reset between reads and returns accumulated in the QENC driver. It is over-complex etc and I see it as un usable for real motion control applications where we have 30 years of experience with many SoC targets and even own old GAL and today VHDL implementations. I have even tried to discuss with you how to join forces at Prague MakerFaire year ago. But then you broke the thing and did not respond to problem reports. We are getting to the state when we need to rail-on the NuttX support again, so I hope that things get into better shape thanks to @Vajnar and my students testing again. Then, in the longer term, I would prefer to have code with lower overhead, support of index mark and 32-bit extension other stuff which we have introduced and works well for other industry targeting MCUs in NuttX https://nuttx.apache.org/docs/latest/components/drivers/character/quadrature.html where introduced QEIOC_SETINDEX allows to use device for precise PMSM control etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
