LightDestory commented on PR #16516: URL: https://github.com/apache/nuttx/pull/16516#issuecomment-2964414291
> Hello @LightDestory and thank you for your first PR welcome to The NuttX Club :-) > > We have automated CI verification for each PR, including build and code formatting, all checks must pass to unblock merge. > > I can see formatting needs some update. Please take a look at: > > * [`master`/CONTRIBUTING.md](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md?rgh-link-date=2025-06-11T21%3A42%3A52Z) > * [nuttx.apache.org/docs/latest/contributing/index.html](https://nuttx.apache.org/docs/latest/contributing/index.html) > > Please update git commit message: > > * topic `boards/nucleo-l432kc: add can support and configuration.` > * please add some short description to the commit so people reading the `git log` will know what/why happened here :-) > > All three sections of the PR are mandatory (Summary, Impact, Testing). Please update :-) > > * Impact - adds CAN support to nucleo-l432kc board and dedicated configuration where CAN is enabled so it is available out of the box for testing. > * Testing - this is very important to show the patch that you provide works and was tested, you can provide build log essentials + testing logs (text preferred). Thanks for your review. I tried to meet all the requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
