cederom commented on PR #16516: URL: https://github.com/apache/nuttx/pull/16516#issuecomment-2964631668
> @LightDestory: I have converted the PR to draft, I will provide text logs of the CAN as soon as I get my hands on the board itself. Thank you :-) In a perfect situation we want to include code that is already verified on a real world hardware. I know this is copy-paste from similar MCU but there may be slight differences that will not allow exact same code to work on different MCU (happened to me recently with stm32) :-) > Regarding the warnings, I just took as reference the can implementation for the l476rg. It would be nice to update the existing code as well when you know it already and there are known issues :-) This fix updates may come already in this PR as part of L432 but then you will have copy-paste for L476 :-) Thanks again @LightDestory :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
