acassis commented on code in PR #16533:
URL: https://github.com/apache/nuttx/pull/16533#discussion_r2145636972
##########
arch/xtensa/src/esp32/Bootloader.mk:
##########
@@ -44,6 +45,10 @@ ifndef MCUBOOT_URL
MCUBOOT_URL = https://github.com/mcu-tools/mcuboot
endif
+ifndef ESP_HAL_3RDPARTY_VERSION_FOR_MCUBOOT
+ ESP_HAL_3RDPARTY_VERSION_FOR_MCUBOOT =
3f02f2139e79ddc60f98ca35ed65c62c6914f079
Review Comment:
suggestion: ifndef ESP_HAL_3RDPARTY_VERSION_FOR_MCUBOOT, define it as
ESP_HAL_3RDPARTY_VERSION, this way we avoid losing updating
ESP_HAL_3RDPARTY_VERSION_FOR_MCUBOOT when ESP_HAL_3RDPARTY_VERSION is updated.
If a new HAL breaks MCUBOOT then a board can define
ESP_HAL_3RDPARTY_VERSION_FOR_MCUBOOT temporally until some fix is found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
